Annotation text with halo - halo not printed#35
Merged
jodygarnett merged 1 commit intomapfish:mainfrom Jul 17, 2025
Merged
Conversation
afabiani
requested changes
Jul 15, 2025
src/test/java/org/mapfish/print/map/renderers/vector/LabelRendererTest.java
Show resolved
Hide resolved
afabiani
approved these changes
Jul 16, 2025
Collaborator
|
Hi @jodygarnett we need also your approval, I guess. Looking forward to hearing from you, then. I'm wondering if there is a way for having the GeoSolutions people more involved on this repo from the admin point of view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #36
The goal of this PR is to fix the handling of outline releated parametrs. Namely:
labelOutlineColor
labelOutlineOpacity
labelOutlineWidth
Previously providing these parameters to LabelRenderer#applyStyle resulted in outline being written on top of label, which resulted in text being covered with outline.
With fix the outline is now being rendered first, and text is being rendered on top of it.
Some example are provided below:
Also added the "labelOutlineMode" parameter, that currently can have "halo" and "stroke" values. The "halo" is default value.
When "stroke" is provided the outline is rendered, but text is not, which result in "hollow" characters.