Merged
Conversation
fc9ef22 to
86f3073
Compare
Member
Author
|
Issue: |
4ab7ddd to
27f5741
Compare
Member
Author
|
Now I get: |
5ac1891 to
b95ec8f
Compare
Member
Author
|
Current issue: It seems that the authentication configuration is not working with cluster mode! |
6c82a26 to
86a4f60
Compare
86a4f60 to
0f296c5
Compare
0f296c5 to
5bc2127
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the acceptance-test setup to support running the examples integration tests in “cluster mode” (DB-backed job queue) in CI, and documents how to run those CI acceptance tests locally.
Changes:
- Add a second CI acceptance-test run using a new
docker-compose-cluster.yamland an env-gated cluster-only test. - Add acceptance-test DB/cluster Spring override config and ensure the tester image includes it.
- Allow passing custom docker-compose flags via
DOCKER_COMPOSE_ARGSinmake acceptance-tests-*targets, and document the workflow.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
examples/src/test/java/org/mapfish/print/PrintApiTest.java |
Gates one secured-template test to run only when the cluster-mode env var is set. |
examples/README.md |
Documents CI acceptance-test commands and how to run with the cluster compose file. |
docker-compose-cluster.yaml |
Adds a DB service and a compose definition intended for cluster-mode acceptance tests. |
core/src/main/resources/mapfish-spring-application-context-override-db.xml |
Sets a default DB port (5432) in the JDBC URL placeholder. |
core/src/main/java/org/mapfish/print/config/access/RoleAccessAssertion.java |
Splits null checks to throw a clearer exception when the security context is unavailable. |
core/extraConfigFor/acceptanceTests/mapfish-spring-application-context-override-db.xml |
Introduces acceptance-test cluster-mode override config (DB job queue + clustered job manager + auth). |
core/Dockerfile |
Copies the new acceptance-test DB override into the tester image and adjusts permissions. |
Makefile |
Adds DOCKER_COMPOSE_ARGS support to acceptance-test up/run/down targets. |
.github/workflows/main.yaml |
Runs acceptance tests twice (normal + cluster) in CI, setting the required env vars for the cluster run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d5a073a to
4ab4fc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JIRA issue: GSMFP-33.