Conversation
0546d0c to
0065e5e
Compare
HTTPs handling should be moved to web.xml
Removed length constraints for the data table in the PrintJobResultExtImpl
From the artifact of the previous workflow run
|
It got a bit messy, because "git pull --rebase" could potentially introduce even more errors, so it was merged without a rebase. Now the merge issues and linter issues are fixed. |
|
Is there a useful logic in the different commits? |
Squash merge with the brief list of the most significant changes as the commit message would be a better option, there is no need to keep them all. |
5b23223 to
8977450
Compare
sebr72
left a comment
There was a problem hiding this comment.
Hi, very good work. I believe most of the comments are minor. On the other hand, please no more push force (to make sure the next review is a matter of minutes rather than hours. Cheers
core/src/main/java/org/mapfish/print/http/ErrorResponseClientHttpResponse.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/servlet/job/impl/hibernate/PrintJobDao.java
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/servlet/job/impl/hibernate/PrintJobDao.java
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/processor/jasper/HttpImageResolver.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/mapfish/print/AbstractMapfishSpringTest.java
Outdated
Show resolved
Hide resolved
8d89dfe to
fe8ca2c
Compare
| public class PrintJobResultExtImpl extends PrintJobResultImpl { | ||
|
|
||
| @Column(length = 1000000000) | ||
| @Column(length = 1000000) |
There was a problem hiding this comment.
Can it be low?, to be tested with an A0 print!
Migrate from spring 5 to spring 7.