Handle 204 no content for SingleImageLayer#3882
Conversation
182eb5e to
c2c8201
Compare
|
@arnaudboudier-sogelink Indeed there was a pb with the tests. So Gradle 9 commit was "remerged" in master. |
954f0d9 to
6eafcce
Compare
|
I have rebased my branch @sebr72 can you check that everything is OK ? |
|
@arnaudboudier-sogelink I had a look at you PR, and I would approve it. But we had started the migration of Spring . So we have to freeze accepting new PRs, to keep our costs down. |
|
Ok no problem, do you know if it will be possible (once my commit will be merged after your spring migration), to backport it also to 3.33 version ? |
|
@arnaudboudier-sogelink I am not sure how we will proceed to get this PR back-ported to 3.33, but I am sure we will find a solution even if it requires extra work (since you created it before Spring 7 was in master) |
6eafcce to
cf53bc8
Compare
|
@arnaudboudier-sogelink MFP is now using Spring 7 in master. Your PR is the next on our list. I'll be mornitoring when it is ready, then do the review. |
|
@arnaudboudier-sogelink Could you please resolve the conflicts before I do the review ? - We would like to do the MFP release 4.0 quite soon and we are hoping it will include your fix, if you could let us know by when you will have time to do it ? |
|
@sebr72 I have corrected the MR conflict hope verything works fine |
83ce080 to
c2473b5
Compare
c2473b5 to
8cb72df
Compare
|
@sebr72 I add to change some code since you updated to spring 7, for the backport in 3.33, it will not possible to just cherry pick this commit (since it is compatible only for spring 7). But I have locally the commit before spring update, so I think i will need to make another PR. Right ? |
|
@arnaudboudier-sogelink Once this is is green, I will have a look at the code and see if a second PR is needed. I guess you might be right about creating a new PR (but not a definite answer yet) |
|
@arnaudboudier-sogelink It should work with a small change in the generated PR. Otherwise we will go with your suggestion of a new PR. |
|
@sebr72 You mean I can just add a commit to this PR that made this PR spring 6 compatible ? And then you are able to backport it to 3.33 ? |
|
@arnaudboudier-sogelink I meant we do as usual, and I see if I can fix the merge from main to 3.33. If I can't I will ask you for help. But it is all fixed now. |
|
@sebr72 Indeed, it seems that my modifications were also working in spring 6. Thank you. Do you know when you will be able to release a new 3.33.x version ? |
|
@sebr72 Do you know when you will be able to make the 3.33.x release ? thank you |
|
@arnaudboudier-sogelink We are planning to do it today. |
When receiving a 204 HTTP status code in tiled requests, Mapfish handles it by inserting a transparent tile. This is not the case for SingleImageLayer (such as WMS), where it results in an error.
I have implemented the same behavior as for tiled requests in this PR.