Conversation
23a6f61 to
9775d31
Compare
Closed
9775d31 to
3d87e50
Compare
Member
Author
|
Finally I required an external dependency do you aggree that it can be backported anyway? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the WebP image format to Mapfish Print 3 by integrating the TwelveMonkeys ImageIO WebP plugin. The implementation uses a property-based activation mechanism (mapfish.image.plugins=true) to scan for and register ImageIO plugins at application startup.
Key Changes
- Added ImageInit class to register WebP ImageIO plugin at startup when enabled via system property
- Added comprehensive documentation for the new
mapfish.image.pluginsproperty - Included integration test with WebP test image and expected output
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/main/java/org/mapfish/print/ImageInit.java | New initialization class that registers WebP ImageIO plugin when property is enabled |
| core/src/main/webapp/WEB-INF/mapfish-print-servlet.xml | Registers ImageInit bean for startup initialization |
| core/build.gradle | Adds TwelveMonkeys ImageIO WebP library dependency (version 3.12.0) |
| docs/src/main/resources/templates/properties.html | New documentation page listing Java system properties including the new mapfish.image.plugins property |
| docs/src/main/resources/templates/_main.html | Reorders navigation menu to place Properties before Configuration |
| docs/src/main/resources/pages.json | Adds properties page to documentation configuration |
| docker-compose.yaml | Enables image plugins in Docker environment via JAVA_OPTS |
| examples/src/test/resources/examples/image_layer_test/requestData-webp.json | Integration test configuration for WebP image layer |
| examples/src/test/resources/examples/image_layer_test/expected_output/requestData-webp.png | Expected test output for WebP image rendering |
| examples/geoserver-data/www/GeoServer.webp | Test WebP image asset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3d87e50 to
f4e4b98
Compare
sebr72
reviewed
Nov 21, 2025
sebr72
approved these changes
Nov 21, 2025
Contributor
sebr72
left a comment
There was a problem hiding this comment.
Looks great, thanks. Only one minor clarification in comment or class name.
sebr72
reviewed
Nov 22, 2025
examples/src/test/resources/examples/image_layer_test/expected_output/requestData-webp.png
Show resolved
Hide resolved
f4e4b98 to
6e25be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3853
See JIRA issue: GSCAR-159.