Merged
Conversation
ae77d19 to
2891fb4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Java codebase by migrating from deprecated Java APIs to modern alternatives, specifically:
- Replacing deprecated
String.repeat()implementations with loop-based string appending - Switching from deprecated
URLconstructors toURL.of()withURIparameters - Updating to modern
StatusPrinter2class instead of deprecatedStatusPrinter - Migrating from
new HashMap<String, String>()to diamond operatornew HashMap<>() - Replacing
list.get(0)andlist.get(list.size()-1)withgetFirst()andgetLast()methods
Reviewed Changes
Copilot reviewed 136 out of 136 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| PrintApiTest.java | Replaced manual loop with String.repeat() for test data generation |
| ExamplesTest.java | Updated imports, exception handling, and URL construction methods |
| Multiple test files | Migrated HashMap instantiation to use diamond operator throughout |
| Various layer/processor test files | Updated list access methods to use getFirst()/getLast() |
| Core source files | Applied modern Java patterns including switch expressions and instanceof pattern matching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sbrunner
approved these changes
Oct 2, 2025
72915f9 to
9a8467e
Compare
9a8467e to
7db1daf
Compare
efd1651 to
40e6b9c
Compare
40e6b9c to
67eba48
Compare
efc3fcb to
0a30473
Compare
sbrunner
approved these changes
Oct 7, 2025
core/src/main/java/org/mapfish/print/attribute/map/CenterScaleMapBounds.java
Show resolved
Hide resolved
0a30473 to
fe8521d
Compare
sbrunner
reviewed
Oct 7, 2025
core/src/main/java/org/mapfish/print/processor/map/scalebar/ScalebarDrawer.java
Outdated
Show resolved
Hide resolved
fe8521d to
7bb0142
Compare
7bb0142 to
f8e941b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop using old Java code where possible.
Remove calls to deprecated methods in tests