Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test resource JSON file to demonstrate the usage of Font Awesome 6 icons for map styling.
- Introduces a JSON configuration with multiple feature styles ("free", "free2", "brands") for Font Awesome icon rendering.
- Sets up properties such as layout, projection, dpi, and styling details for each feature type.
Comments suppressed due to low confidence (1)
examples/src/test/resources/examples/simple/requestData-fontawesome-6.json:59
- The label value '\uf0a4' is used in both the '[type = "free"]' and '[type = "free2"]' style blocks. Please verify if this duplication is intentional or if a different icon should be used for 'free2' to improve clarity.
"label": "\uf0a4",
d385002 to
07879a0
Compare
Contributor
|
@sbrunner Please add a comment in the description to explain the renaming of font-awesome to font-awesome-5. And confirm this won't introduce any regression or change of behaviour. |
Member
Author
|
I renamed font-awesome to font-awesome-5 to have a coherent way to add font-awesome-6! In the test I do, I confirm that I didn't see any regressions :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed font-awesome to font-awesome-5 to have a coherent way to add font-awesome-6!
See also: GSGMF-2167