Fix MDC for project working with logback 1.2.x#3626
Merged
sebr72 merged 1 commit intomapfish:masterfrom May 28, 2025
Merged
Conversation
sebr72
approved these changes
May 28, 2025
Contributor
There was a problem hiding this comment.
@arnaudboudier-sogelink Hope this helps.
Since you use MFP in your own "non-standard" way. It might be interesting for others if you share a link to your gihub in a new Discussion, with some quick pointers on how it is integrated ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We integrate your library into our spring boot 2 project, which can use only 1.2.x logback versions.
https://docs.spring.io/spring-boot/docs/2.7.18/reference/html/dependency-versions.html#appendix.dependency-versions
But in logback 1.2.x, call MDC.setContextMap with a null object create a null pointer.
The modifications does not change the actual behaviour and provide retocompatibilty. I don't know if it's okay for you.