Fix: CreateMapPagesProcessor ignore zoomToFeature on pages in order to keep the split#3619
Merged
sebr72 merged 3 commits intomapfish:masterfrom May 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the map paging processor to ignore zoomToFeatures on pages, preserving the intended page split behavior. Key changes include:
- A new configuration file (config.yaml) defining settings for zoomToFeatures, paging, and scalebar.
- A new test (CreateMapPagesProcessorZoomToFeatureTest.java) verifying that the CreateMapPagesProcessor behaves as expected when zoomToFeatures is disabled.
- A modification to the CreateMapPagesProcessor (setting input.zoomToFeatures to null) to enforce the ignored zoom feature.
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/src/test/resources/org/mapfish/print/processor/map/paging_processor_zoom_to_features_test/config.yaml | Added configuration for zoomToFeatures and related attributes for paging and scalebar. |
| core/src/test/java/org/mapfish/print/processor/map/CreateMapPagesProcessorZoomToFeatureTest.java | New test file to validate the processor’s behavior when zoomToFeatures is ignored. |
| core/src/main/java/org/mapfish/print/processor/map/CreateMapPagesProcessor.java | Modified to set input.zoomToFeatures to null, ensuring the zoomToFeatures attribute is ignored. |
Files not reviewed (3)
- core/src/test/resources/org/mapfish/print/processor/map/paging_processor_zoom_to_features_test/requestData.json: Language not supported
- core/src/test/resources/org/mapfish/print/processor/map/paging_processor_zoom_to_features_test/simpleReport.jrxml: Language not supported
- core/src/test/resources/org/mapfish/print/processor/map/paging_processor_zoom_to_features_test/thinline.sld: Language not supported
core/src/main/java/org/mapfish/print/processor/map/CreateMapPagesProcessor.java
Show resolved
Hide resolved
sebr72
requested changes
May 12, 2025
Contributor
sebr72
left a comment
There was a problem hiding this comment.
Thanks for this work, and good test coverage. I would have approved the PR but we are not Ok with adding dead code. even in test.
.../src/test/java/org/mapfish/print/processor/map/CreateMapPagesProcessorZoomToFeatureTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/mapfish/print/processor/map/CreateMapPagesProcessorZoomToFeatureTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/mapfish/print/processor/map/CreateMapPagesProcessorZoomToFeatureTest.java
Outdated
Show resolved
Hide resolved
…to keep the split
…gesProcessor.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
d8798fb to
1aeec44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.