Skip to content

Use getRawStatusCode to avoid getting an exception on fake status code 999, convert it to 406 Not Acceptable#3497

Merged
sbrunner merged 2 commits into3.31from
no-exception
Nov 4, 2024
Merged

Use getRawStatusCode to avoid getting an exception on fake status code 999, convert it to 406 Not Acceptable#3497
sbrunner merged 2 commits into3.31from
no-exception

Conversation

@sbrunner
Copy link
Copy Markdown
Member

@sbrunner sbrunner commented Nov 1, 2024

No description provided.

@sbrunner sbrunner requested a review from sebr72 November 1, 2024 08:34
@sbrunner sbrunner changed the base branch from master to 3.31 November 1, 2024 08:43
@sbrunner sbrunner added the backport master Backport the pull request to the 'master' branch label Nov 1, 2024
@sbrunner sbrunner marked this pull request as ready for review November 1, 2024 09:27
@sbrunner sbrunner requested a review from gberaudo November 1, 2024 11:35
sebr72
sebr72 requested changes Nov 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 406 status code and add test

sebr72
sebr72 requested changes Nov 1, 2024
View reviewed changes
@sbrunner sbrunner changed the title Use getRawStatusCode to don't get an exception on fake status code 999 Use getRawStatusCode to don't get an exception on fake status code 999, convert it to 406 Not Acceptable Nov 1, 2024
@sebr72 sebr72 changed the title Use getRawStatusCode to don't get an exception on fake status code 999, convert it to 406 Not Acceptable Use getRawStatusCode to avoid getting an exception on fake status code 999, convert it to 406 Not Acceptable Nov 1, 2024
@sebr72 sebr72 force-pushed the no-exception branch 2 times, most recently from 5a0e1c7 to e07994a Compare November 3, 2024 02:00
@sbrunner
Copy link
Copy Markdown
Member Author

sbrunner commented Nov 4, 2024

Is it ready to be merged?

@sebr72
Copy link
Copy Markdown
Contributor

sebr72 commented Nov 4, 2024 •
edited
Loading

@sbrunner If you are satisfied with my changes, please go ahead with the merge.

@sbrunner sbrunner merged commit 55f4202 into 3.31 Nov 4, 2024
@sbrunner sbrunner deleted the no-exception branch November 4, 2024 08:43
@c2c-bot-gis-ci-2 c2c-bot-gis-ci-2 removed the backport master Backport the pull request to the 'master' branch label Nov 4, 2024
@c2c-bot-gis-ci-2 c2c-bot-gis-ci-2 mentioned this pull request Nov 4, 2024
Merged
@geo-ghci-int geo-ghci-int bot added this to the 3.31.2 milestone Nov 4, 2024
@sbrunner sbrunner added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebr72 sebr72 sebr72 approved these changes

@gberaudo gberaudo Awaiting requested review from gberaudo

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

3.31.2

Development

Successfully merging this pull request may close these issues.

4 participants

@sbrunner @sebr72 @gberaudo @c2c-bot-gis-ci-2