-
Notifications
You must be signed in to change notification settings - Fork 267
fix: revert "Bump nopt from 8.0.0 to 9.0.0 (#919)" #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit c842373.
benmccann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for missing this in #919
|
@cclauss we should probably try to get this out quickly as a hot fix. I could merge it, but would need someone to cut the release |
|
Agreed. Who cut the last release? |
|
@ductoanthanh did you cut a release by chance? We might need your help cutting another one with this change in it |
|
@benmccann I cut the last release. My change in #923 was not supposed to be a breaking change therefore I didn't make a major version change. The breaking change was introduced in one of the earliers PRs which was merged. As for the change in this PR, do you think the version should be bumped to 2.0.3? I am not sure if it is even allowed on the registry to unpublish a package. |
|
@benmccann Let's merge this one then. What's the latest you need a new release to be published? |
|
Merged. Whenever you get a chance for the release would be great. Thanks! |
|
Looks like this was just released as 2.0.3. Thank you both! |
This reverts commit c842373.
Fixes #924.