Add ic and jct information to step intersection#1532
Merged
abhishek1508 merged 1 commit intomainfrom Feb 3, 2023
Merged
Conversation
836656f to
ddd9739
Compare
Codecov Report
@@ Coverage Diff @@
## main #1532 +/- ##
============================================
+ Coverage 77.28% 77.36% +0.07%
- Complexity 957 965 +8
============================================
Files 132 134 +2
Lines 4095 4109 +14
Branches 588 588
============================================
+ Hits 3165 3179 +14
Misses 679 679
Partials 251 251
|
dzinad
reviewed
Jan 26, 2023
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/InterChange.java
Outdated
Show resolved
Hide resolved
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/Junction.java
Outdated
Show resolved
Hide resolved
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/Junction.java
Outdated
Show resolved
Hide resolved
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/Junction.java
Outdated
Show resolved
Hide resolved
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
...ces-directions-models/src/test/java/com/mapbox/api/directions/v5/models/InterChangeTest.java
Outdated
Show resolved
Hide resolved
services-directions-models/src/test/java/com/mapbox/api/directions/v5/models/JunctionTest.java
Show resolved
Hide resolved
...irections-models/src/test/java/com/mapbox/api/directions/v5/models/StepIntersectionTest.java
Show resolved
Hide resolved
...irections-models/src/test/java/com/mapbox/api/directions/v5/models/StepIntersectionTest.java
Show resolved
Hide resolved
4188c38 to
762046e
Compare
dzinad
reviewed
Jan 30, 2023
...ces-directions-models/src/test/java/com/mapbox/api/directions/v5/models/InterChangeTest.java
Outdated
Show resolved
Hide resolved
dzinad
approved these changes
Jan 30, 2023
762046e to
5ffb098
Compare
LukasPaczos
reviewed
Feb 2, 2023
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/InterChange.java
Outdated
Show resolved
Hide resolved
services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/InterChange.java
Outdated
Show resolved
Hide resolved
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
5ffb098 to
70f3160
Compare
Contributor
Author
|
@LukasPaczos I need an approval before I can merge |
LukasPaczos
reviewed
Feb 2, 2023
Contributor
LukasPaczos
left a comment
There was a problem hiding this comment.
Some name changes still needed (please update all occurrences, I haven't highlighted all of them), otherwise, LGTM.
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
...es-directions-models/src/main/java/com/mapbox/api/directions/v5/models/StepIntersection.java
Outdated
Show resolved
Hide resolved
70f3160 to
899a4ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ICandJCTinformation toStepIntersection.