-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Rename text-size to text-font-size #4168
Copy link
Copy link
Closed
Labels
breaking change ⚠️Requires a backwards-incompatible change to the APIRequires a backwards-incompatible change to the APIcross-platform 📺Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Metadata
Metadata
Assignees
Labels
breaking change ⚠️Requires a backwards-incompatible change to the APIRequires a backwards-incompatible change to the APIcross-platform 📺Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
From @1ec5 on January 6, 2017 22:43
The
text-sizeproperty should be renamedtext-font-size. As part of #218, it would be shortened tofont-size.Contrary to the property’s current name, it does not specify the dimensions of the overall label the way
text-max-widthdoes. Instead, it specifies the font size in pixels. This inconsistency means a developer using the iOS or macOS SDK would be tempted to set the property to aCGSizeorNSSizevalue instead of a number./cc @lucaswoj @jfirebaugh
Copied from original issue: mapbox/mapbox-gl-style-spec#650