From @1ec5 on January 5, 2017 10:35
circle-pitch-scale should be renamed circle-scale-alignment.
mapbox/mapbox-gl-style-spec#459 (comment) proposed {circle,icon,text}-pitch-scale properties as complements to the {circle,icon,text}-{rotation,pitch}-alignment properties. As discussed in mapbox/mapbox-gl-native#6098, the circle-pitch-scale name incorrectly implies a numeric value. It’s also inconsistent with the rest of the properties:
| Property |
|
a feature’s |
according to the map or viewport’s |
when the map has |
circle-rotation-alignment |
aligns |
rotation |
rotation |
rotation |
circle-pitch-alignment |
aligns |
pitch |
pitch |
pitch |
circle-pitch-scale |
aligns |
scale |
scale |
pitch |
Renaming circle-pitch-scale to circle-scale-alignment would make the property’s type more obvious and better harmonize the name with the others:
| Property |
does what |
a feature’s |
according to the map or viewport’s |
when |
circle-scale-alignment |
aligns |
scale |
scale |
pitch |
/cc @jfirebaugh @lucaswoj
Copied from original issue: mapbox/mapbox-gl-style-spec#645
From @1ec5 on January 5, 2017 10:35
circle-pitch-scaleshould be renamedcircle-scale-alignment.mapbox/mapbox-gl-style-spec#459 (comment) proposed
{circle,icon,text}-pitch-scaleproperties as complements to the{circle,icon,text}-{rotation,pitch}-alignmentproperties. As discussed in mapbox/mapbox-gl-native#6098, thecircle-pitch-scalename incorrectly implies a numeric value. It’s also inconsistent with the rest of the properties:circle-rotation-alignmentcircle-pitch-alignmentcircle-pitch-scaleRenaming
circle-pitch-scaletocircle-scale-alignmentwould make the property’s type more obvious and better harmonize the name with the others:circle-scale-alignment/cc @jfirebaugh @lucaswoj
Copied from original issue: mapbox/mapbox-gl-style-spec#645