-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Make "circle-blur" units be pixels #4099
Copy link
Copy link
Closed
Labels
breaking change ⚠️Requires a backwards-incompatible change to the APIRequires a backwards-incompatible change to the APIcross-platform 📺Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Metadata
Metadata
Assignees
Labels
breaking change ⚠️Requires a backwards-incompatible change to the APIRequires a backwards-incompatible change to the APIcross-platform 📺Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
From @mcwhittemore on November 12, 2015 17:8
@anandthakker raised a question today about if it is safe for circle blur to be greater than one. The spec is a bit unclear here as it only explains what the effect of 1 should be, leaving both < 1 and > 1 to be unclear.
Looking into mapbox-gl-js circle-blur doesn't seem to be getting windowed which leads me to assume it is ok if it is greater than one. Is this right?
Either way we should update the spec to clear this kind of question up. The other blur's are in pixels, rather than an alpha channel.
Copied from original issue: mapbox/mapbox-gl-style-spec#378