Reimplement directory mirroring portion of robloach/component-installer#98
Merged
Merged
Conversation
This reverts commit f94dffb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
robloach/component-installer is abandoned and incompatible with Composer 2. This has been forcing us to ship with a very old Composer version that is in turn incompatible with PHP 8. Composer 1.x itself has been deprecated in early 2021.
This pull reimplements the portions of robloach/component-installer that Mapbender actually relies on to function, namely copying specified package files from the vendor tree into the web components tree after package installation. This should fully resolve Composer 2 incompatibilities and allow installation to run on PHP 8.
Asset mangling / recompilation parts of robloach/component-installer are not reimplemented. This means no "...-built.js" / "...-built.css" files are generated. Current Mapbender versions do not need these. Custom project code sourcing any component package asset via "-built.js" / "-built.css" will need to be updated to reference the individual source file(s) instead.