Support Vector Tiles (via Mapbox Style JSONs)#1748
Merged
Conversation
…freshing source, check if resource is json
…nfo behaviour into common base class for WMS/WMTS (WIP), make feature info behaviour more generic (WIP)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive support for Vector Tiles as a new data source using Mapbox Style JSON specifications. The feature enables rendering of vector tile layers directly in Mapbender with full integration into the layertree, feature info functionality, and YAML configuration support.
Key changes include:
- Implementation of a complete Vector Tiles bundle with source/instance entities, form types, and frontend JavaScript classes
- Refactoring of the feature info system to use promises and handle source-specific implementations
- Enhanced accessibility features including keyboard navigation for scale selector and feature info tabs
- Addition of projection support validation for layers
Reviewed Changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Mapbender/VectorTilesBundle/ | Complete new bundle implementing vector tiles support with entities, forms, loaders, and configuration |
| src/Mapbender/CoreBundle/Resources/public/mapbender.element.featureInfo.js | Refactored to use promise-based feature info loading from sources |
| src/Mapbender/CoreBundle/Resources/public/mapbender-model/ | Split monolithic source.js into separate files and added GetFeatureInfoSource base class |
| src/Mapbender/WmsBundle/Resources/public/mapbender.geosource.wms.js | Updated to extend GetFeatureInfoSource and removed duplicate scale checking logic |
| src/Mapbender/ManagerBundle/Component/ImportHandler.php | Enhanced import handling to support different source types via factory pattern |
swinkelmann
approved these changes
Jul 25, 2025
swinkelmann
left a comment
Contributor
There was a problem hiding this comment.
I have nothing to complain about. 🥇
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables a new data source to be used: Vector Tiles using the Mapbox Style JSON Specification.
Preconditions
composer install(or manually enable the VectorTilesBundle and runcomposer update, the mapbender/openlayers6-es5 needs to be present in version >= 10.6.1.2)bin/console doctrine:schema:update --forceThings that work
Things that don't work (yet)
Other changes
Usage (GUI)
Usage (YAML):
Use the following sample yaml application and adapt to your needs: