Fix/digitizer bring your own printdata#1123
Merged
Merged
Conversation
…sers of the printDigitizerFeature method must now bring their own attribute mapping, or at the very least the actual feature object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes mbPrintClient.printDigitizerFeature API to expect an attribute mapping (preferred), or alternatively a native OpenLayers feature.
Old-style invocations with just a Digitizerish feature id and Digitizerish "schema" name are no longer allowed and will throw an error.
This frees the Mapbender print backend from looking up FeatureType / DataStore services, which is completely unsafe anyway.
Every Digitizer Element can potentially define its FeatureType set in its backend configuration. Service lookup is not possible in those cases.
See mapbender/mapbender-digitizer#69