Fix/revert html element to html element#1122
Merged
Merged
Conversation
This reverts commit a6893be.
This reverts commit 663e1c2.
This reverts commit 6ea089b.
This reverts commit c190197.
This reverts commit 7e0ab80.
This reverts commit d03c874.
This reverts commit 37df40d.
This reverts commit 480032d.
This reverts commit ddb7daf.
…nt.htmlelement.js" This reverts commit b0a3880.
This reverts commit 1afdaa8.
…ent" This reverts commit 0f89796.
This reverts commit 00b09e7.
This reverts commit 15a38ae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTMLElement was used as a stomping ground for certain developments before vis-ui.js and data-source were spun off. It has accumulated a lot of logic that is only really relevant for Digitizer and certain other data-sourcey Mapbender Elements.
Data Source 0.1.11 has everything it needs to keep even quite old Digitizer versions running happily, with no more need for any supporting magic in HTMLElement. In fact, as of 0.1.11, DataSource's BaseElement doesn't inherit from HTMLElement anymore.
As such, it is now safe to restore HTMLElement to its original purpose: a thing that renders a piece of markup.
This pull removes data-sourcey configuration preprocessing magic prepareItem, prepareItems, isAssoc.
This pull removes the Ajax entry point handler (single action
configuration).This pull removes processing logic for
jsSrcandcssoptions. These have never actually been configurable. Through the entire history of the repository, the HTMLElement form type has never defined form fields with these names. We can only speculate that a child class or two may have defined them, but never HTMLElement itself. UPGRADING.md now has instructions on what to do in these cases.This pull restores
This pull changes the rendering logic for
html-element-inlineto emit a span instead of a div. This resolved certain CSS gotchas, and actually allowed the complete removal of the HTMLElement CSS rules.The remaining HTMLElement only renders the markup defined in its
contentoption, which may also use Twig functionality by the way. It doesn't have a JavaScript widget constructor, and it doesn't have any predefined CSS rules.