Add new (dormant) compiler pass that can modify default form themes#1030
Merged
werrolf merged 1 commit intoMar 15, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull adds a compiler pass class that can rewrite the default form theme(s). Pass accepts
from,toconstructor arguments.Pull does not engage this compiler pass in any way.
This is intended to
Example usage:
Place into any Bundle class's
buildmethod (MapbenderCoreBundle works fine):This makes every form in the entire Mapbender backend render in Bootstrap 3 theme. There are some layouting quirks with "extended collections", "region properties" etc. So this is not recommended for general use. It just proves that the replacement method works on a base level.