Update contributing development section#74
Merged
manuzhang merged 1 commit intomanuzhang:mainfrom Feb 25, 2024
Merged
Conversation
The instructions didn't get you a working environment for testing. They also were missing a number checks that happen in CI. This now documents everything you need to run locally to get CI to pass except for the "running on different platforms". All the Ubuntu checks seems mostly as "safety" but the Windows checks can discover bugs that don't occur on Linux. I haven't documented that at this time as it was outside of the scope of what I wanted to accomplish with this change.
manuzhang
approved these changes
Feb 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instructions didn't get you a working environment for testing. They also were missing a number checks that happen in CI. This now documents everything you need to run locally to get CI to pass except for the "running on different platforms". All the Ubuntu checks seems mostly as "safety" but the Windows checks can discover bugs that don't occur on Linux. I haven't documented that at this time as it was outside of the scope of what I wanted to accomplish with this change.