Skip to content

Allow special characters in directory name, optimization#68

Merged
manuzhang merged 4 commits intomanuzhang:mainfrom
marmotton:main
Aug 18, 2023
Merged

Allow special characters in directory name, optimization#68
manuzhang merged 4 commits intomanuzhang:mainfrom
marmotton:main

Conversation

@marmotton
Copy link
Copy Markdown
Contributor

The keys of self.files are url encoded. This leads to errors when the path of a file contains special characters as src_path is not url encoded.

Modifications:

  • url encode the directory path
  • generate self.files in the on_files() function instead of on_page_markdown() (this is only an optimization, not strictly needed)
  • test (directory with special characters)

@manuzhang manuzhang merged commit d0add3f into manuzhang:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants