Support validating anchors containing emojis#67
Merged
manuzhang merged 2 commits intomanuzhang:mainfrom Jul 18, 2023
johnthagen:emoji-anchors
Merged
Support validating anchors containing emojis#67manuzhang merged 2 commits intomanuzhang:mainfrom johnthagen:emoji-anchors
manuzhang merged 2 commits intomanuzhang:mainfrom
johnthagen:emoji-anchors
Conversation
Contributor
Author
|
@manuzhang I tested this PR against our codebase that is adopting emojis and it worked as expected. Would you be able to review? Thanks. |
manuzhang
approved these changes
Jul 18, 2023
Contributor
Author
|
@manuzhang Could you release 0.14.0 onto PyPI? Thanks! |
Owner
|
I think I will release 1.0.0 given the major changes in dependencies. |
Contributor
Author
|
@manuzhang Sounds great. I will also do a test of 1.0.0 after it's released as well. |
Contributor
Author
|
@manuzhang Confirmed that the 1.0.0 release works great! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64