Skip to content

Add support for ignoring URLs (no fetching) with wildcards.#62

Merged
manuzhang merged 2 commits intomanuzhang:mainfrom
es-fabricemarie:support-ignore-urls
Jul 31, 2023
Merged

Add support for ignoring URLs (no fetching) with wildcards.#62
manuzhang merged 2 commits intomanuzhang:mainfrom
es-fabricemarie:support-ignore-urls

Conversation

@es-fabricemarie
Copy link
Copy Markdown
Contributor

Support ignoring a configurable list of URLs.

Useful when a documentation project has a lot of URLs that are not reachable or that are not authorized to access without additional cookies. Organization level Github private repositories are a good example.

@manuzhang
Copy link
Copy Markdown
Owner

have you tried out raise_error_excludes?

@es-fabricemarie
Copy link
Copy Markdown
Contributor Author

I have tried raise_error_excludes but unlike ignore_urls, raise_error_excludes actually:

  • fetch the URL first (I don't want to fetch URLs that I know are "broken" for the tool, because it's very slow).
  • does not support wildcards except the exact * (you cannot do https://github/toto/* for example)

That's why I suggest we need both.

@manuzhang
Copy link
Copy Markdown
Owner

@es-fabricemarie I think the points you raised need to be fixed for raise_error_excludes. How about enhancing it with your solutions for ignore_urls?

@manuzhang
Copy link
Copy Markdown
Owner

manuzhang commented May 8, 2023

@es-fabricemarie do you have time to port your changes to raise_error_excludes? If not, I'd like to pick up your work and co-author a PR with you.

@es-fabricemarie
Copy link
Copy Markdown
Contributor Author

@es-fabricemarie do you have time to port your changes to raise_error_excludes? If not, I'd like to pick up your work and co-author a PR with you.

Hi @manuzhang, sorry I just noticed your message. Sure please go ahead, I will not have the time.

@manuzhang
Copy link
Copy Markdown
Owner

After more thoughts and experiments, I'd like to keep this feature apart from raise_error_excludes. Sorry for holding up this PR for so long.

@manuzhang manuzhang merged commit 383b2ef into manuzhang:main Jul 31, 2023
@es-fabricemarie es-fabricemarie deleted the support-ignore-urls branch August 1, 2023 11:47
@es-fabricemarie es-fabricemarie restored the support-ignore-urls branch August 1, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants