Improve error handling#61
Merged
manuzhang merged 7 commits intomanuzhang:mainfrom Apr 13, 2023
kolibri91:improve-error-handling
Merged
Improve error handling#61manuzhang merged 7 commits intomanuzhang:mainfrom kolibri91:improve-error-handling
manuzhang merged 7 commits intomanuzhang:mainfrom
kolibri91:improve-error-handling
Conversation
johnthagen
approved these changes
Apr 13, 2023
Contributor
|
Can confirm this PR fixes #58, thanks! |
Contributor
Author
|
@johnthagen I stripped to code again to keep the actual changes minimal. |
johnthagen
approved these changes
Apr 13, 2023
Contributor
|
@manuzhang Would you mind doing a Thanks! |
Owner
|
I made a mistake of not including this in |
Contributor
|
@manuzhang Can confirm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be possible to add urls like mentioned in #58 to the exclude list but the plugin still logs a warning so that
mkdocsfails in strict mode. That's the mainly the reason why does #58 fail. Within this PR, the error handling is slightly improved.The log of the warning is moved to another level where the config is known.
With this change, it's possible to check the exclusion list before a warning is logged.
report_invalid_urlCloses #58