Fix very minor Makefile issue in spidermonkey clean target (#109)#110
Merged
manugarg merged 1 commit intomanugarg:masterfrom Mar 23, 2022
Merged
Fix very minor Makefile issue in spidermonkey clean target (#109)#110manugarg merged 1 commit intomanugarg:masterfrom
clean target (#109)#110manugarg merged 1 commit intomanugarg:masterfrom
Conversation
Contributor
Author
|
@manugarg any interest in merging this? Or maybe you committed a fix yourself already? I'm just testing out the GitHub mobile app, apologies if you already fixed this, I vaguely remember you commenting on this but I don't see it here |
Owner
|
Thanks for this. Sorry for the super long delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #109 and while I didn't test it across different platforms, I did confirm there is no breakage with the build or clean targets on a Linux system with a glibc+gcc toolchain
If you don't think this is really necessary please feel free to close it
Thanks!