Limited fix on svn proc_open pipe handling#333
Closed
obmsch wants to merge 1 commit intomantisbt-plugins:masterfrom
Closed
Limited fix on svn proc_open pipe handling#333obmsch wants to merge 1 commit intomantisbt-plugins:masterfrom
obmsch wants to merge 1 commit intomantisbt-plugins:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is is just a reordering on the pipes and the rational about it.
Due to limitations on the buffering of pipes and therefore possible
resulting deadlocks, the order the pipes are read is crucial.
The reordering (STDOUT before STDERR) will not(!) prevent a deadlock, if the
output of the process to STDERR exceeds the max buffered size on STDERR.
Better handle the unlikely error, than get stuck on the goods.