Show delayed inline errors from print_header_redirect()#1955
Merged
dregad merged 2 commits intomantisbt:master-2.26from Jan 24, 2024
Merged
Show delayed inline errors from print_header_redirect()#1955dregad merged 2 commits intomantisbt:master-2.26from
dregad merged 2 commits intomantisbt:master-2.26from
Conversation
dregad
commented
Jan 4, 2024
| layout_page_begin(); | ||
| echo '<br /><div class="center">'; | ||
| print_link_button( $p_url, lang_get( 'proceed' ) ); | ||
| echo '</div>'; |
Member
Author
There was a problem hiding this comment.
Let me know if you think it would be better to call html_operation_successful( $p_url ); here instead of just printing a Proceed button.
Member
Author
There was a problem hiding this comment.
OK, I'll add the error message, I believe it makes things clearer for the user.
31092a2 to
ec3444c
Compare
vboctor
approved these changes
Jan 14, 2024
Following the deprecation of print_successful_redirect() function in issue #5189, calling it shows a blank page when $g_stop_on_errors = ON and $g_display_errors[E_USER_DEPRECATED] = DISPLAY_ERROR_INLINE because Mantis does not complete the redirection due to presence of a handled error. print_header_redirect() now displays a basic "proceed" page, with redirection enabled only when $g_stop_on_errors = ON, allowing any delayed inline error messages to be shown. Fixes #33480
When delayed inline error messages are displayed on a page with a redirection, call html_operation_successful() to inform the user that the operation completed successfully despite the errors. Issue #33480
ec3444c to
5e65518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the deprecation of print_successful_redirect() function in issue #5189, calling it shows a blank page when $g_stop_on_errors = ON and $g_display_errors[E_USER_DEPRECATED] = DISPLAY_ERROR_INLINE because Mantis does not complete the redirection due to presence of a handled error.
print_header_redirect() now displays a basic "proceed" page, with redirection enabled only when $g_stop_on_errors = ON, allowing any delayed inline error messages to be shown.
Fixes #33480