Merged
Conversation
atrol
reviewed
Sep 19, 2020
atrol
reviewed
Sep 19, 2020
674a4bb to
c657e97
Compare
Member
|
I like the cleanup, but worry about some of these strings may be used by plugins. Thoughts? Should we have a deprecated strings section for ones that are likely to be used - e.g. print, update, etc? |
41d3924 to
3e7e477
Compare
Member
Author
@vboctor I can think of 3 possible approaches here
I don't think option 2 is a good approach at all, and once #1696 gets merged, option 3 will only add marginal value (displaying the actual deprecated localization instead of the language string key + a warning). IMO it is not worth the effort to implement 3, and I recommend to stick with option 1. |
3e7e477 to
3e66dbf
Compare
Member
Author
|
FTR I just merged #1696 after fixing the last review comment, so I rebased this branch on top of it. |
There were several language strings defined for the same label: edit_link, bugnote_edit_link, update_bug_button. Adding a new generic short string and replace all occurences of the old ones in the code.
There were several language strings defined for the same label: actiongroup_menu_delete, delete_attachment_button, delete_bug_button, delete_filter_button, delete_link, delete_relationship_button. Adding a new generic short string and replace all occurences of the old ones in the code.
Using the generic update language string and removing duplicate plugin_update.
There were several language strings defined for the same label: actiongroup_menu_move, move_bug_button. Adding a new generic short string and replace all occurences of the old ones in the code.
There were several language strings defined for the same label: actiongroup_menu_close, close_bug_button. Adding a new generic short string and replace all occurences of the old ones in the code.
There were several language strings defined for the same label: add_user_to_monitor, add_new_relationship_button. Adding a new generic short string and replace all occurences of the old ones in the code.
There were several language strings defined for the same label: click_to_login, login_button, login_link. Adding a new generic short string and replace all occurences of the old ones in the code.
- switch and related constants (on, off) - vote_added_msg
3e66dbf to
4565713
Compare
Member
Author
|
Without further feedback on this, I assume you agree with my proposed approach and will proceed with merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several duplicated language strings defined for the same labels. We should use a single, common string for a given purpose.
Additionally, there are a few old, unused strings that need to be removed.
Fixes #27298