Merged
Conversation
- Created a VmCloner class to store the Vm and Cloudlets Cloner Functions. It also defines the maximum number of VM clones to be created using a VmCloner object. Now, the HostFaultInjection class accepts a VmCloner object, instead of setting Vm Cloner and Cloudlets Cloner individually. - Changed the faultArrivalTimesGenerator into the HostFaultInjection class documentation to indicate the faultArrivalTimesGenerator is considered to be in hours (not minutes anymore). - Included a FaultToleranceLevel inside the JSON SLA Contracts (see SlaContract class). Now, the number of VMs to create for each broker is based on this k-fault-tolerance level. The AWS EC2 Template to be used to create these k VMs is based on the max price the customer is willing to pay hourly for all VMs. This way, the price for each VM template cannot be higher than maxPrice/k. If this is the case, the cheaper VM will be selected and the k will be recomputed to avoiding violating the contract price. If even the cheaper VM is more expensive than the contract price, it will be created only one instance of it, violating the contract price, but avoiding the customer services to be stopped.
# Conflicts: # cloudsim-plus/src/main/java/org/cloudsimplus/faultinjection/HostFaultInjection.java
manoelcampos
requested changes
Jun 5, 2017
Collaborator
manoelcampos
left a comment
There was a problem hiding this comment.
Just small changes.
| @Override | ||
| protected List<Vm> createVms(DatacenterBroker broker) { | ||
| final int numVms = (int) getTemplatesMap().get(broker).getMaxNumberOfVmsForCustomer(); | ||
| numVms = getContract(broker).getMinFaultToleranceLevel(); |
Collaborator
There was a problem hiding this comment.
Remove this numVms attribute and declare it as a final local variable.
Contributor
Author
There was a problem hiding this comment.
It is as an attribute of the class, since from the value of the amount of vms that have been set the cloudlets will be defined.
| * | ||
| * @return | ||
| */ | ||
| public double getPercentageOfCostMeetingSla() { |
Collaborator
There was a problem hiding this comment.
Renamed the method to getPercentageOfBrokersMeetingCost
| * inside the failed VM. | ||
| * | ||
| * @author raysaoliveira | ||
| * @since CloudSim Plus 1.2.2 |
Collaborator
|
|
||
| /** | ||
| * Gets the {@link Function} to be used to clone Vm's {@link Cloudlet}s. | ||
| * It is a Function which, when called, creates a clone of cloudlets |
Collaborator
There was a problem hiding this comment.
Change "It is a Function which, when called," to "When the given Function is called,"
| * Gets the maximum number of Vm clones to create. | ||
| * For instance, if this value is equal to 2, | ||
| * it means if all VMs from a given broker are destroyed multiple times, | ||
| * a clone will be created only 2 times. For the 3rd time all VMs are destroyed again, |
Collaborator
There was a problem hiding this comment.
Change "For the 3rd time all VMs are destroyed again, no clone will be created." to "If all VMs are destroyed again for the 3rd time, no clone will be created."
| private int clonedVmsNumber; | ||
|
|
||
| /** | ||
| * Creates a {@link Vm} cloner which creates the maximum of 1 clone. |
Collaborator
# Conflicts: # cloudsim-plus/src/main/java/org/cloudsimplus/faultinjection/VmCloner.java
manoelcampos
approved these changes
Jun 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #81
New VmCloner Class
Introduces a
VmClonerclass to store theVmandCloudletsClonerFunctions. It also defines the maximum number of Vm clones to be created using aVmClonerobject.Now, the
HostFaultInjectionclass accepts aVmClonerobject, instead of setting aVmCloner andCloudletsCloner individually.Fault Arrival Times
Changed the
faultArrivalTimesGeneratorattribute into theHostFaultInjectionclass documentation to indicate the attribute is considered to be in hours (not minutes anymore).K-Fault-Tolerance Level
Included a
FaultToleranceLevelinside the JSON SLA Contracts (seeSlaContractclass). Now, the number of Vms to create for each broker is based on thisk-fault-tolerance level. The AWS EC2 Template to be used to createkVMs required to ensure such a fault-tolerance level is based on the max price the customer is willing to pay hourly for all VMs.This way, the price for each VM template cannot be higher than
maxPrice/k. If this is the case, the cheaper Vm will be selected and thekvalue will be recomputed to avoid violating the contract price. If even the cheaper Vm is more expensive than the contract price, it will be created only one instance of it. Such a condition violates the contract price, but avoids the customer services to be stopped.Available Examples