Skip to content

Backport: Further improve search output (#2823)#3006

Merged
jonashaag merged 2 commits intomamba-org:1.xfrom
delsner:backport-search-improvements
Nov 23, 2023
Merged

Backport: Further improve search output (#2823)#3006
jonashaag merged 2 commits intomamba-org:1.xfrom
delsner:backport-search-improvements

Conversation

@delsner
Copy link
Copy Markdown
Contributor

@delsner delsner commented Nov 23, 2023

This backports patch #2823 to 1.x in order to address #3005.

entry.second[0],
std::vector(entry.second.begin() + 1, entry.second.end())
std::vector(entry.second.begin() + 1, entry.second.end()),
Context::instance().output_params.verbosity > 0
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a slight difference to the original patch #2823; since the context singleton isn't available in the entrypoint in libmamapy yet, we're retrieving the context singleton here directly.

@delsner
Copy link
Copy Markdown
Contributor Author

delsner commented Nov 23, 2023

CI seems to fail due to pytest.skip issue for which I backported another patch (#2952) in #3007

@jonashaag jonashaag force-pushed the backport-search-improvements branch from dcd5990 to d5ce764 Compare November 23, 2023 12:44
@jonashaag jonashaag merged commit 49aa56e into mamba-org:1.x Nov 23, 2023
@delsner delsner deleted the backport-search-improvements branch November 23, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants