Skip to content

(VDB-1125) Enable full and lite API vs same DB#89

Merged
rmulhol merged 1 commit intostagingfrom
vdb-1125-lite-and-full
Jan 13, 2020
Merged

(VDB-1125) Enable full and lite API vs same DB#89
rmulhol merged 1 commit intostagingfrom
vdb-1125-lite-and-full

Conversation

@rmulhol
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol commented Jan 10, 2020

  • Omit internal tables from public and maker schemas from the API
  • Add alternative names for tables that conflict

Screen Shot 2020-01-10 at 11 33 32 AM
Screen Shot 2020-01-10 at 11 33 55 AM

m0ar
m0ar approved these changes Jan 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@m0ar m0ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

gslaughl
gslaughl approved these changes Jan 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@gslaughl gslaughl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@rmulhol rmulhol force-pushed the vdb-1124-remove-full-sync branch 2 times, most recently from 3e7df08 to 443db39 Compare January 13, 2020 21:56
@rmulhol rmulhol changed the base branch from vdb-1124-remove-full-sync to staging January 13, 2020 22:14
@rmulhol rmulhol force-pushed the vdb-1125-lite-and-full branch from dd5f1f1 to 97c8e61 Compare January 13, 2020 22:38
(VDB-1125) Enable full and lite API vs same DB
3242a49 
- Omit internal tables from public and maker schemas from the API
- Add alternative names for tables that conflict
@rmulhol rmulhol force-pushed the vdb-1125-lite-and-full branch from 97c8e61 to 3242a49 Compare January 13, 2020 22:44
@rmulhol rmulhol merged commit 5fe572b into staging Jan 13, 2020
@rmulhol rmulhol deleted the vdb-1125-lite-and-full branch January 13, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaoandrew yaoandrew Awaiting requested review from yaoandrew

@elizabethengelman elizabethengelman Awaiting requested review from elizabethengelman

2 more reviewers

@m0ar m0ar m0ar approved these changes

@gslaughl gslaughl gslaughl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmulhol @m0ar @gslaughl