Updating README to explain current usage#87
Conversation
685432e to
b03470d
Compare
rmulhol
left a comment
There was a problem hiding this comment.
Thanks for taking the lead on this!
|
|
||
| ### Getting the project | ||
| Download the transformer codebase to your local local `GOPATH` via: | ||
| `go get github.com/makerdao/vdb-mcd-transformers` |
There was a problem hiding this comment.
Does this work? I thought we might not be able to use go get as long as we're importing the Geth fork
There was a problem hiding this comment.
Good call, I had forgotten about that. I think go get should work for getting the transformers repo - since it doesn't directly depend on geth, but geth through VDB. But you're totally right that we'll probably have to use git clone for the vdb repo.
That said, I wonder if we should use the same method for both repos, just for clarity/consistency?
README.md
Outdated
| These core commands can be run via Docker images which is the preferred method, or they can be built and run via the | ||
| command line interface. In either method, a postgres database will first need to be created: | ||
| 1. Install Postgres | ||
| 1. Create a superuser for yourself and make sure `psql --list` works without prompting for a password. |
There was a problem hiding this comment.
Do you know if this is still necessary? Thinking we might be able to avoid it as long as the db user/pw are included in config
There was a problem hiding this comment.
It looks like we still need to create a supersuser for creating the citext extension which we're using to allow for case insensitivity for urn identifiers.
CREATE EXTENSION IF NOT EXISTS citext;
ERROR: permission denied to create extension "citext"
HINT: Must be superuser to create this extension.
I wonder if we should invest some time into figuring out a way around this, so we can remove the necessity for superusers.
There was a problem hiding this comment.
I might be focused too much on the part that says "make sure psql --list works without prompting for a password" - thinking maybe we can avoid that as long as the user/pw has the right permissions to run the migrations
There was a problem hiding this comment.
gotcha, that makes sense to me. does the change in f69b277 work?
f69b277 to
eadf42c
Compare
eadf42c to
66b4fd8
Compare
A couple of things that I think would be helpful to add: