Conversation
Closed
7e2cc05 to
eaccd13
Compare
rmulhol
approved these changes
Jan 9, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
🥇
Really elegant solution here - nice work!
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("Deny Transformer", func() { |
eaccd13 to
f78198d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of @yaoandrew's work by generalizing the
Cat.relytransformer to work across all contracts withrelyevents. Also took it a step further by combining the transformers forrelyanddenyevents into a single transformer, which I called theauthtransformer, but we don't have to include that commit depending on how people feel about it.