Conversation
|
Like I said in the call I'm unable to debug this locally since I've got DB troubles, but shouldn't be anything big. @rmulhol I remember touching some tests where additional parameters were required for maxRetry etc on the new watcher functionality. IDK why this was even missing, maybe I screwed something up? 🤔 |
9a09eab to
7a51a29
Compare
transformers/test_data/deal.go
Outdated
| constants.AddressColumn: rawDealLog.Address.Hex(), | ||
| event.LogFK: DealHeaderSyncLog.ID, | ||
| event.HeaderFK: DealHeaderSyncLog.HeaderID, | ||
| event.AddressFK: rawDealLog.Address.Hex(), |
There was a problem hiding this comment.
I think that most of the tests that use these models for assertions, we look up the address id in the test itself rather than relying on this hex string. So maybe we should remove this from the test model since it's not an accurate representation of what a model will look like similar to how we're handling it for test dent?
There was a problem hiding this comment.
Nice catch! Yeah that hex definitely doesn't belong there.
Remove constants.AddressColumn in favour of event.AddressFK Fix formatting + tests
7a51a29 to
d8c768f
Compare
💯