(VDB-1051) Create flop vow storage transformer#65
Merged
Conversation
3f486b4 to
9e62ddc
Compare
Contributor
|
LGTM but withholding approval since this shouldn't be merged until 0.2.17 is cut 👍 |
elizabethengelman
approved these changes
Dec 30, 2019
Contributor
elizabethengelman
left a comment
There was a problem hiding this comment.
🖖looks good!
I think this could probably get merged in whenever now that we've cut v0.2.17 🎉
| Tau = "tau" | ||
| Kicks = "kicks" | ||
| Live = "live" | ||
| Vow = "vow" |
Contributor
There was a problem hiding this comment.
totally doesn't have to be part of this PR, but I wonder if we should rename this file? 🤔
Contributor
Author
There was a problem hiding this comment.
Yeah good point. Seems like these vars might be more at home in constants/keys.go, with the rest of our key/column strings
9e62ddc to
9d1c316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.