Conversation
- Populate config and pass non-nil converter
- Since we're passing the db connection as an arg and no longer setting it as a property of the converter, we no longer need the initializer to have a pointer to the converter
be83956 to
6a748ac
Compare
gslaughl
left a comment
There was a problem hiding this comment.
Nice catch! Would be nice if we could use our actual initializers in our integration tests. I can't remember why we're not but I'm sure there's a good reason 🤔
|
Interesting thought! I'd definitely be in favor of using more of our actual source code in the integration tests 👍 I think the main reason we aren't doing this now is to make it easier to configure the block number that the transformer executes over. The initializer derives the starting block number from the config, and returns a struct implementing the |
Fixes an oversight from my previous PR 😅
Second commit is not as urgent but felt like a worthwhile simplification - can remove if others aren't on board