(VDB-1080) Add Spot file par transformer#62
Conversation
749b780 to
a7af01a
Compare
| ( | ||
| id SERIAL PRIMARY KEY, | ||
| header_id INTEGER NOT NULL REFERENCES headers (id) ON DELETE CASCADE, | ||
| log_id BIGINT NOT NULL REFERENCES header_sync_logs (id) ON DELETE CASCADE, |
There was a problem hiding this comment.
Postgraphile basically asks for an index on every FK. So if we want to indulge it, we'll need one on log_id.
| google.golang.org/grpc v1.23.1/go.mod h1:Y5yQAOtifL1yxbo5wqy6BxZv8vAUGQwXBOALyacEbxg= | ||
| gopkg.in/alecthomas/kingpin.v2 v2.2.6/go.mod h1:FMv+mEhP44yOT+4EoQTLFTRgOQ1FBLkstjWtayDeSgw= | ||
| gopkg.in/bsm/ratelimit.v1 v1.0.0-20160220154919-db14e161995a/go.mod h1:KF9sEfUPAXdG8Oev9e99iLGnl2uJMjc5B+4y3O7x610= | ||
| gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM= |
There was a problem hiding this comment.
I'm kind of weirded out by how erratic our dependencies are all of a sudden 🤔
|
|
||
| var EventTransformerInitializer transformer.EventTransformerInitializer = event.Transformer{ | ||
| Config: shared.GetEventTransformerConfig(constants.SpotFileParTable, constants.SpotFileParSignature()), | ||
| Converter: &par.Converter{}, |
There was a problem hiding this comment.
Are we moving away from using pointers here? Tbh I don't know why we'd use one or the other in this instance, just thinking about consistency
There was a problem hiding this comment.
Yeah good catch - I think we should trend toward only using them when we have a good reason, like needing to modify the internal state of the struct. Will remove here since we pass the db connection as an arg to the function (rather than calling SetDB on the converter)
a7af01a to
c078221
Compare
No description provided.