Conversation
rmulhol
left a comment
There was a problem hiding this comment.
🚢
Dig it, but might check with @elizabethengelman to verify this doesn't create unnecessary rebase frustration if it's merged before VDB-950
| UNIQUE (header_id, address_id, vat) | ||
| ); | ||
|
|
||
| CREATE INDEX flip_vat_address_id_index |
There was a problem hiding this comment.
seems like sometimes above we're calling this same relationship an address_index - would be down to choose either that or address_id_index and use it everywhere
| @@ -189,7 +203,12 @@ COMMENT ON TABLE maker.flip_kicks IS E'@name flipKicksStorage'; | |||
| -- SQL in this section is executed when the migration is rolled back. | |||
| DROP INDEX maker.flip_kicks_address_id_index; | |||
| DROP INDEX maker.flip_kicks_kicks_index; | |||
There was a problem hiding this comment.
Not introduced by this PR but I wonder why we need this index? I guess it's probably used in a join 🤔
There was a problem hiding this comment.
Nice catch! Currently it's not getting referenced by any other table, but my guess is we were using it at some point to get a created value for bids. Now we're getting created from flip_kick events instead of this storage table, so it seems safe to delete the index.
| LANGUAGE sql; | ||
|
|
||
| COMMENT ON FUNCTION get_latest_flip_bid_guy | ||
| IS E'@omit'; |
| CREATE INDEX flip_bid_bid_bid_id_index | ||
| ON maker.flip_bid_bid (bid_id); | ||
| CREATE INDEX flip_bid_bid_address_id_index | ||
| CREATE INDEX flip_bid_bid_address_index |
8b462c3 to
6b403b7
Compare
Copy over migrations from vDB Omit convenience functions from postgraphile
6b403b7 to
19ed65f
Compare
Add the indexes that postgraphile complains about lacking when run with the
--no-ignore-indexesflagAlso I noticed that when running postgraphile with the
apiandmakerschemas, a bunch of convenience methods being used by our trigger tables are exposed, so I went ahead and addedomittags to those. It might make more sense to exclude them a different way (maybe a different schema?), but I figured this might work as a first pass.