Conversation
rmulhol
left a comment
There was a problem hiding this comment.
🏃 ✂️ 🎉
Really awesome that we can speed up tests this way! I feel like I've run into trouble in the past when values were assigned in var declarations rather than a BeforeEach, but not w/r/t db initialization and the tests here are passing, so 👍
| "github.com/makerdao/vulcanizedb/pkg/datastore/postgres" | ||
| "io/ioutil" | ||
| "testing" | ||
|
|
There was a problem hiding this comment.
Can you remove spaces between imports in this file and then run goimports -w transformers/component_tests/queries/queries_suite_test.go
|
@rmulhol I think the issue has been that we have initialised a completely new connection per test, which we hadn't explicitly closed until you added your |
|
👍 definitely no problems here - mostly just noting since the pattern of: is usually pretty bulletproof, so all things being equal I wouldn't abandon it without a good reason (which we definitely have here). I think I've seen issues where: can sometimes result in zero-valued vars (though I could be misremembering - thought I had seen that when the function depended on other vars/functions that may not have been evaluated in time to make a successful assignment 🤔). Also could be that I'm confusing things in a (with no var declaration) |
🏎️