Conversation
There was a problem hiding this comment.
Thanks for knocking this out!
Seems like a lot of these files would benefit from goimports -w. One annoyance with that is that it seems like that will always insert a line break between core utils and other deps, but doesn't uniformly assemble all the other deps together without line breaks (which requires deliberately removing the breaks before running goimports)
| log_id BIGINT NOT NULL REFERENCES header_sync_logs (id) ON DELETE CASCADE, | ||
| urn_id INTEGER NOT NULL REFERENCES maker.urns (id) ON DELETE CASCADE, | ||
| ilk_id INTEGER NOT NULL REFERENCES maker.ilks (id) ON DELETE CASCADE, | ||
| u TEXT NOT NULL, |
There was a problem hiding this comment.
Should u potentially be an int referencing public.addresses (id)? Not sure if it matters if this is always just the address for the vow, but thinking that would match our current approach elsewhere
There was a problem hiding this comment.
Didn't see that for vat_suck which is very similar, that's why I didn't :)
There was a problem hiding this comment.
🤔 seems like maybe we should make the change in both places? just thinking that the addresses table should be a reliable source for every known address for the contracts/events we track
There was a problem hiding this comment.
Hmm maybe that's true.. Would you mind creating tasks for this? I'm quite sure there are more ad-hoc addresses that we don't reference there that we should also catch in that cleanup.
c187c57 to
45c6ad7
Compare
No description provided.