Merged
Conversation
m0ar
approved these changes
Dec 10, 2019
rmulhol
reviewed
Dec 10, 2019
54de987 to
0227240
Compare
rmulhol
reviewed
Dec 12, 2019
| var _ = Describe("Vat grab converter", func() { | ||
| var converter vat_grab.VatGrabConverter | ||
| var converter vat_grab.Converter | ||
| db := test_config.NewTestDB(test_config.NewTestNode()) |
Contributor
There was a problem hiding this comment.
Liked Gabe's comment on another PR - we should clean the test db in a BeforeEach. Also, I think it'd be good to explicitly declare the db as a var (rather than assigning with :=). Could be wrong, but I feel like I've run into scoping issues when something like this is declared implicitly
0227240 to
4f57dbd
Compare
4f57dbd to
7818119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.