Merged
Conversation
m0ar
approved these changes
Dec 9, 2019
Contributor
m0ar
left a comment
There was a problem hiding this comment.
Looking good!
The compiled binary vdb-mcd-transformers is checked in, coudl you remove that and add it to .gitignore? 😊
| flopKickEvent.ColumnValues[event.HeaderFK] = headerOne.Id | ||
| flopKickEvent.ColumnValues[event.LogFK] = flopKickLog.ID | ||
| flopKickEvent.ColumnValues[event.AddressFK] = addressId | ||
| flopKickEvent.ColumnValues["bid_id"] = strconv.Itoa(fakeBidId) |
Contributor
There was a problem hiding this comment.
Is there a constant for "bid_id"?
| headerId := insertHeader(db, blockNumber) | ||
| flopKickLog := test_data.CreateTestLog(headerId, db) | ||
| _, insertErr := db.Exec(flop_kick.InsertFlopKickQuery, headerId, bidId, 0, 0, "", contractAddressId, flopKickLog.ID) | ||
| _, insertErr := db.Exec(insertFlopKickQuery, headerId, bidId, 0, 0, "", contractAddressId, flopKickLog.ID) |
Contributor
There was a problem hiding this comment.
Not a huge fan of these zero-value arguments without knowing what they are. Assign them to some local variables?
039016f to
12d95ce
Compare
9aed809 to
c626bbe
Compare
c626bbe to
c195d5a
Compare
yaoandrew
approved these changes
Dec 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.