Skip to content

Update table names to uses constants#36

Merged
elizabethengelman merged 4 commits intostagingfrom
update-constants-table-names
Dec 5, 2019
Merged

Update table names to uses constants#36
elizabethengelman merged 4 commits intostagingfrom
update-constants-table-names

Conversation

@elizabethengelman
Copy link
Copy Markdown
Contributor

@elizabethengelman elizabethengelman commented Dec 4, 2019 •
edited
Loading

cut from #34

@elizabethengelman elizabethengelman changed the base branch from staging to vdb-1002-vow-file December 4, 2019 22:23
@elizabethengelman elizabethengelman changed the base branch from vdb-1002-vow-file to vdb-1003-vow-flog December 4, 2019 22:24
@elizabethengelman elizabethengelman force-pushed the update-constants-table-names branch from 16e5a55 to 6a3b919 Compare December 4, 2019 22:28
@elizabethengelman elizabethengelman changed the title Update constants table names Update table names to uses constants Dec 4, 2019
@elizabethengelman elizabethengelman force-pushed the update-constants-table-names branch from 6a3b919 to b1300e1 Compare December 4, 2019 23:21
rmulhol
rmulhol approved these changes Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

gslaughl
gslaughl approved these changes Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@gslaughl gslaughl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@elizabethengelman elizabethengelman changed the base branch from vdb-1003-vow-flog to staging December 5, 2019 17:16
@elizabethengelman elizabethengelman changed the base branch from staging to vdb-1003-vow-flog December 5, 2019 17:16
@elizabethengelman elizabethengelman force-pushed the update-constants-table-names branch from b1300e1 to 98b8a2d Compare December 5, 2019 17:47
@elizabethengelman elizabethengelman changed the base branch from vdb-1003-vow-flog to staging December 5, 2019 17:51
@elizabethengelman elizabethengelman force-pushed the update-constants-table-names branch from 98b8a2d to 0ae64ba Compare December 5, 2019 17:59
@elizabethengelman elizabethengelman merged commit 09c6e1a into staging Dec 5, 2019
@elizabethengelman elizabethengelman deleted the update-constants-table-names branch December 5, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m0ar m0ar Awaiting requested review from m0ar

@yaoandrew yaoandrew Awaiting requested review from yaoandrew

2 more reviewers

@rmulhol rmulhol rmulhol approved these changes

@gslaughl gslaughl gslaughl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elizabethengelman @rmulhol @gslaughl