Use test_config file to setup a test blockchain for integration tests#335
Merged
elizabethengelman merged 3 commits intostagingfrom Oct 7, 2020
Merged
Conversation
03e4d43 to
657cfad
Compare
paytonrules
reviewed
Oct 6, 2020
test_config/test_config.go
Outdated
| return client.NewRpcClient(raw, ipc), ethclient.NewClient(raw), nil | ||
| } | ||
|
|
||
| func getBlockChain(rpcClient client.RpcClient, ethClient *ethclient.Client) (core.BlockChain, error) { |
Contributor
There was a problem hiding this comment.
Why return an error here if this function can never error?
Contributor
Author
There was a problem hiding this comment.
nice catch! i'll update that
paytonrules
approved these changes
Oct 6, 2020
Contributor
paytonrules
left a comment
There was a problem hiding this comment.
Just one small comment.
rmulhol
approved these changes
Oct 6, 2020
657cfad to
07515ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some changes based on comments in #328: #328 (comment). Totally up for making some more improvements too!