Skip to content

Vdb backfill storage#329

Merged
elizabethengelman merged 2 commits intobetafrom
vdb-backfill-storage
Oct 1, 2020
Merged

Vdb backfill storage#329
elizabethengelman merged 2 commits intobetafrom
vdb-backfill-storage

Conversation

@elizabethengelman
Copy link
Copy Markdown
Contributor

No description provided.

@elizabethengelman elizabethengelman marked this pull request as draft September 30, 2020 20:55
@elizabethengelman elizabethengelman marked this pull request as ready for review October 1, 2020 16:32
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

echo "Running backfillStorage from block <NEEDS UPDATE> to <NEEDS UPDATE>"
./vulcanizedb backfillStorage -s=10739859 -e=10906308 --config config.toml # TODO: update block numbers before next run
echo "Running backfillStorage from block 109326661 to 10970892"
./vulcanizedb backfillStorage -s=109326661 -e=109708921 --config config.toml # TODO: update block numbers before next run
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nbd but it seems like the ending block numbers differ by 1 between the logs and the config

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I know this sorta breaks precedent but I'd be in favor of starting 1 block before the deploy - can't really explain why but it has something to do with guaranteeing that we get all the deployment stuff, and I think it should be super low cost (process is lightweight on blocks without diffs)

]
rank = "0"

transformerNames = []
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

echo "Running backfillStorage from block <NEEDS UPDATE> to <NEEDS UPDATE>"
./vulcanizedb backfillStorage -s=10739859 -e=10906308 --config config.toml # TODO: update block numbers before next run
echo "Running backfillStorage from block 10932663 to 10970892"
./vulcanizedb backfillStorage -s=10932663 -e=109708921 --config config.toml # TODO: update block numbers before next run
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the MCD_FLIP_COMP_A_1.1.2 deploy block - 1

@elizabethengelman elizabethengelman force-pushed the vdb-backfill-storage branch 2 times, most recently from a399e93 to 86320d3 Compare October 1, 2020 21:24
echo "Running backfillStorage from block <NEEDS UPDATE> to <NEEDS UPDATE>"
./vulcanizedb backfillStorage -s=10739859 -e=10906308 --config config.toml # TODO: update block numbers before next run
echo "Running backfillStorage from block 10932663 to 10970892"
./vulcanizedb backfillStorage -s=10932663 -e=10970892 --config config.toml # TODO: update block numbers before next run
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This starting block is the MCD_FLIP_COMP_A_1.1.2 deploy block - 1, and the ending block is the block about when the geth process was restarted with these addresses.

@elizabethengelman elizabethengelman merged commit be220b9 into beta Oct 1, 2020
@elizabethengelman elizabethengelman deleted the vdb-backfill-storage branch October 1, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants