Vdb 1519 add usdt and pax staging#316
Conversation
| @@ -43,6 +43,10 @@ | |||
| address = "0xec25Ca3fFa512afbb1784E17f1D414E16D01794F" | |||
There was a problem hiding this comment.
reminder: need to update these to use the versioned names
0ee5268 to
c7d236d
Compare
1197382 to
28056fb
Compare
This is a DSValue contract, and not an OSM contract, and doesn't emit events typical of an OSM contract.
5836aec to
26f8467
Compare
paytonrules
left a comment
There was a problem hiding this comment.
My ignorance is talking here - but how come you didn't have to write any actual behavior? It appears to all be config and magic numbers.
|
@paytonrules this PR is just config updates because the new collaterals consist of new flip, median and osm contracts (for each collateral). And the way that those transformers are created, we can just add a new contracts for them to watch. |
|
@elizabethengelman Thanks, how do you know what the numbers are for those in the tests? Are those block numbers for actual data? None of this is meant to be a criticism of your code, I just want to understand this better. |
|
@paytonrules Yeah, totally! Those numbers are block numbers, and then values from actual events. I went onto etherscan and found events on the contracts and then just added those to the integration tests. |
cut from #300