Skip to content

Use cat_file_chop_lump as transformer label#311

Merged
rmulhol merged 1 commit intobetafrom
fix-chop-lump-config
Sep 16, 2020
Merged

Use cat_file_chop_lump as transformer label#311
rmulhol merged 1 commit intobetafrom
fix-chop-lump-config

Conversation

@rmulhol
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol commented Sep 16, 2020

  • in initializer
  • currently, the table name and transformer label are overloaded.
    If the table name doesn't match the transformer label (as it did
    not in this case, where the table was cat_file_chop_lump and the
    label was cat_file_chop_lump_dunk), then the initializer does not
    find addresses associated with the table name.
  • temporarily setting up transformer label to match table name, but
    it would be good to circle back and decouple these things.
  • also would be nice to start execute in CI to verify config works.

- in initializer
- currently, the table name and transformer label are overloaded.
  If the table name doesn't match the transformer label (as it did
  not in this case, where the table was cat_file_chop_lump and the
  label was cat_file_chop_lump_dunk), then the initializer does not
  find addresses associated with the _table_ name.
- temporarily setting up transformer label to match table name, but
  it would be good to circle back and decouple these things.
- also would be nice to start execute in CI to verify config works.
@rmulhol rmulhol force-pushed the fix-chop-lump-config branch from 8f5bc29 to 4d92385 Compare September 16, 2020 16:47
@rmulhol rmulhol merged commit 8b112e0 into beta Sep 16, 2020
@rmulhol rmulhol deleted the fix-chop-lump-config branch September 16, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants