Use cat_file_chop_lump as transformer label#311
Merged
Conversation
- in initializer - currently, the table name and transformer label are overloaded. If the table name doesn't match the transformer label (as it did not in this case, where the table was cat_file_chop_lump and the label was cat_file_chop_lump_dunk), then the initializer does not find addresses associated with the _table_ name. - temporarily setting up transformer label to match table name, but it would be good to circle back and decouple these things. - also would be nice to start execute in CI to verify config works.
8f5bc29 to
4d92385
Compare
elizabethengelman
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the table name doesn't match the transformer label (as it did
not in this case, where the table was cat_file_chop_lump and the
label was cat_file_chop_lump_dunk), then the initializer does not
find addresses associated with the table name.
it would be good to circle back and decouple these things.