Conversation
b437872 to
569816b
Compare
elizabethengelman
left a comment
There was a problem hiding this comment.
Looking good! I'll probably take another look once #300 is merged in, so I can more easily see what this PR is adding.
8601d63 to
795c8f8
Compare
elizabethengelman
left a comment
There was a problem hiding this comment.
The only thing that should probably be updated before merging this in is how we're getting the FlipFileCatSignature.
| Topic: constants.FlipFileCatSignature(), | ||
| } | ||
|
|
||
| XIt("fetches and transforms a Flip File Cat event", func() { |
There was a problem hiding this comment.
I think that there was a cat file event at 10769102, so we can probably un-pend this integration test.
There was a problem hiding this comment.
I didn't see anything on the MCD_FLIP_BAT_A_1.1.0, MCD_FLIP_ETH_A_1.1.0, MCD_FLIP_KNC_A_1.1.0, or MCD_FLIP_PAXUSD_A_1.1.1 contracts. I've been assuming this event would be from calling function file(bytes32 what, address data) where what = "cat" on one of those Flip contracts
There was a problem hiding this comment.
Doh, you're right. I was looking at the wrong contract. Sorry about that!
795c8f8 to
4107dd5
Compare
48ae59b to
25e6be0
Compare
25e6be0 to
8525224
Compare
This has been rebased with #300. Probably makes sense to wait until that's in staging and this has been rebased again.