(VDB-1605) 1.1.0 cat storage [staging]#302
Merged
rmulhol merged 5 commits intovdb-1594-1.1.0-addresses-stagingfrom Sep 22, 2020
Merged
(VDB-1605) 1.1.0 cat storage [staging]#302rmulhol merged 5 commits intovdb-1594-1.1.0-addresses-stagingfrom
rmulhol merged 5 commits intovdb-1594-1.1.0-addresses-stagingfrom
Conversation
9d05442 to
c0a4b71
Compare
34a2056 to
72589f0
Compare
- include cat field
paytonrules
reviewed
Sep 21, 2020
| import ( | ||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/core/types" | ||
| //"github.com/ethereum/go-ethereum/core" |
paytonrules
reviewed
Sep 21, 2020
| var catAddress = constants.GetContractAddress("MCD_CAT_1.1.0") | ||
| var StorageTransformerInitializer storage.TransformerInitializer = storage.Transformer{ | ||
| Address: common.HexToAddress(catAddress), | ||
| StorageKeysLookup: storage.NewKeysLookup(v1_0_0.NewKeysLoader(&mcdStorage.MakerStorageRepository{}, catAddress)), |
Contributor
There was a problem hiding this comment.
Should this be using v1_1_0.NewKeysLoader here?
paytonrules
approved these changes
Sep 21, 2020
Contributor
paytonrules
left a comment
There was a problem hiding this comment.
Couple minor comments, but this is a branch to branch so I am assume it'll get looked at again.
72589f0 to
7c729a3
Compare
…ging (VDB-1606) Add Flip v1.1.0 storage transformers [staging]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.